-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micro transpose op ported and tested for TFLM #48192
Conversation
Added the Add* function for the missing Builtin operator Fill
…ed micro BUILD file and transpose_test.cc
Thanks for contributing to TensorFlow Lite Micro. To keep this process moving along, we'd like to make sure that you have completed the items on this list:
We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
CLA provided |
@googlebot I fixed it. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Hi @victorromeo, I think I succesfully signed the CLA, but the bot keeps complaining. What about your side? Did you sign with the same email used for the commit? Thanks! |
@dmpiergiacomo I have determined that the email the commits were done under was not a verifiable email address and as a result, I am unable to sign the CLA, without modifying the email addresses first. I've tried a |
@victorromeo, thank you for the explanation, I understand the problem. I think the easiest solution would be the manual intervention of a Googler. I can see here that they should have the power to override the Another solution could be a git rebase through which I could amend your commits switching to the email address |
Alternative 3) Please let me know if you'd like me to re-commit my changes on a clean branch, using the correct email account.
Agreed, as using a Googler will maintain the code base in its current state, however either solution is fine by me. |
@dmpiergiacomo Can you please make sure to use same GitHub username and email-id associated with it. |
Hi @gbaned apologies for the delay, I had some hard deadlines to respect.
I believe I am using the same GitHub username and email-id associated with it. If not, could you please clarify? From my understanding the issue is that the email used by @victorromeo to push his changes can no longer be accessed to sign Google CLA. We would therefore kindly ask you to override the CLA flag with your admin power. Would this be possible? Thank you. |
Thank you @gbaned for forcing the CLA flag to yes. It looks like the community CI build now fails, probably something has changed in the meanwhile. Does it make sense to debug it, or better to wait for @advaitjain review first? Thank you. |
Sorry for the delay here. I'm going to close the current PR since #48192 is doing the same and is soon going to be merged. |
Hi @advaitjain, I believe you might have provided a wrong link in your last message. If it's the case, could you provide the correct one? Thanks. Are we talking about #47446 maybe? |
Fixes #45695
Fixes #43472
Addition of TRANSPOSE operation and its relevant test file to TF Lite for Microcontrollers. This operation has been successfully tested in the following ways:
transpose_test
with BazelDidn't find op for builtin opcode 'TRANSPOSE' version '2'
disappearedMore details abut point 1.
The command used is:
It returns:
More details abut point 2.
I always build locally my version of TFLM with the command:
Before applying the fixes of this PR, the error on the target nRF52840 DK was:
Now, after applying the fixes of this PR, the error disappears and the code can process further at runtime.