Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the segfault in tf.raw_ops.SparseCountSparseOutput. #49347

Merged
merged 1 commit into from May 20, 2021
Merged

Fix the segfault in tf.raw_ops.SparseCountSparseOutput. #49347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion tensorflow/core/kernels/count_ops.cc
View file
Open in desktop
Expand Up @@ -193,9 +193,17 @@ class SparseCount : public OpKernel {
}

bool is_1d = shape.NumElements() == 1;
int num_batches = is_1d ? 1 : shape.flat<int64>()(0);
auto shape_vector = shape.flat<int64>();
int num_batches = is_1d ? 1 : shape_vector(0);
int num_values = values.NumElements();

for (int b = 0; b < shape_vector.size(); b++) {
OP_REQUIRES(context, shape_vector(b) >= 0,
errors::InvalidArgument(
"Elements in dense_shape must be >= 0. Instead got:",
shape.DebugString()));
}

OP_REQUIRES(context, num_values == indices.shape().dim_size(0),
errors::InvalidArgument(
"Number of values must match first dimension of indices.",
Expand Down