Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-picks for 0.11.0rc1 #5023

Merged
merged 9 commits into from
Oct 19, 2016
Merged

cherry-picks for 0.11.0rc1 #5023

merged 9 commits into from
Oct 19, 2016

Conversation

yifeif
Copy link
Contributor

@yifeif yifeif commented Oct 18, 2016

No description provided.

Zongheng Yang and others added 5 commits October 14, 2016 15:57
The argument controls on the save path, whether the Save (V1) op or the SaveV2
op is used.

By default it's set to V1, so this should be a backward-compatible change.
We'll wait for a few weeks (>= 4), resolve issues that come up, and switch it
to the new V2 format.
Change: 134406969

(cherry picked from commit cd2ded6)
 - tensorflow/tools/dist_test/Dockerfile.local:39:0.10.0
 - tensorflow/contrib/cmake/setup.py:29:0.10.0
 - tensorflow/g3doc/get_started/os_setup.md:399:0.10
Change: 134354710

(cherry picked from commit 0c20dd9)
Let the user of the load_resource method decide whether to log or not.
Change: 136052944

(cherry picked from commit 9352b2e)
Change: 136158550

(cherry picked from commit 60bb54e)
@mention-bot
Copy link

@yifeif, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gunan, @vrv and @dave-andersen to be potential reviewers.

@yifeif
Copy link
Contributor Author

yifeif commented Oct 18, 2016

Cherry-pick the bazel certificate issue fix as well. @tensorflow-jenkins test this please.

@yifeif
Copy link
Contributor Author

yifeif commented Oct 18, 2016

@tensorflow-jenkins test this please.

@yifeif
Copy link
Contributor Author

yifeif commented Oct 18, 2016

The failed GPU test has been flaky. May I get a LG?

@drpngx
Copy link
Contributor

drpngx commented Oct 18, 2016

For the flakes, do you want to test these?

  • fix the windows cmake: 136491988, 136504874, 136513790
  • gradients_test: 136498075

@gunan
Copy link
Contributor

gunan commented Oct 18, 2016

Windows cmake needs many more fixes in the release branch, so please ignore
that one. For gradients test lets cherrypick that as it will probably flake
in release tests too.

On Oct 18, 2016 6:18 PM, "drpngx" notifications@github.com wrote:

For the flakes, do you want to test these?

  • fix the windows cmake: 136491988, 136504874, 136513790
  • gradients_test: 136498075


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5023 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHlCOeCVwN2k94VbG8KcBoY65Blpw21Sks5q1UWwgaJpZM4KZRtC
.

@yifeif
Copy link
Contributor Author

yifeif commented Oct 18, 2016

Sounds good. Will cherrypick the fix for gradient test once #5054 is in.

Change: 136505720

(cherry picked from commit 2c3a42e)
@yifeif
Copy link
Contributor Author

yifeif commented Oct 19, 2016

@tensorflow-jenkins test this please.

@gunan
Copy link
Contributor

gunan commented Oct 19, 2016

As we do not have windows support on this branch, we can call all tests passing.
Merging.

@gunan gunan merged commit 7aa800a into tensorflow:r0.11 Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants