Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with tf.summary.create_file_writer when non-scalar values are passed #51715

Conversation

yongtang
Copy link
Member

This PR tries to fix the issue raised in #46909 where
tf.summary.create_file_writer crashes when non-scalar values are passed.

This PR fixes #46909.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

…re passed

This PR tries to fix the issue raised in 46909 where
tf.summary.create_file_writer crashes when non-scalar values are passed.

This PR fixes 46909.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Aug 27, 2021
@google-cla google-cla bot added the cla: yes label Aug 27, 2021
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Aug 27, 2021
@gbaned gbaned self-assigned this Aug 30, 2021
@gbaned gbaned added the comp:core issues related to core part of tensorflow label Aug 30, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 30, 2021
@gbaned gbaned added prtype:bugfix PR to fix a bug comp:ops OPs related issues and removed comp:core issues related to core part of tensorflow labels Aug 30, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 30, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 30, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 30, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Aug 31, 2021
@copybara-service copybara-service bot merged commit 874bda0 into tensorflow:master Aug 31, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Aug 31, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Aug 31, 2021
@yongtang yongtang deleted the 46909-tf.summary.create_file_writer branch September 1, 2021 01:27
mihaimaruseac added a commit that referenced this pull request Oct 25, 2021
…90b453b50bcc65b2769e-on-r2.4

Merge pull request #51715 from yongtang:46909-tf.summary.create_file_…
mihaimaruseac added a commit that referenced this pull request Oct 25, 2021
…90b453b50bcc65b2769e-on-r2.5

Merge pull request #51715 from yongtang:46909-tf.summary.create_file_…
mihaimaruseac added a commit that referenced this pull request Oct 25, 2021
…90b453b50bcc65b2769e-on-r2.6

Merge pull request #51715 from yongtang:46909-tf.summary.create_file_…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:ops OPs related issues prtype:bugfix PR to fix a bug size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

tf.summary.create_file_writer aborts
4 participants