Replacement for #51392 #51861
Merged
Replacement for #51392 #51861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Doing this because a performance regression was observed in some cases (need to investigate further). - The new kernels are now only used if determinism is required or if TF_USE_DETERMINISTIC_SEGMENT_REDUCTIONS=1 is set. - This commit also fixes the determinism test on Windows.
benbarsdell
force-pushed
the
gpu-SegmentReductions-redo
branch
from
a276796
to
92b294f
Compare
google-ml-butler
bot
added
kokoro:force-run
google-ml-butler
bot
removed
awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmission of #51392 but with the new kernels disabled by default as suggested in #51392 (comment) (new changes are all in the second commit).
It also attempts to fix the determinism test failure on Windows.
cc @nluehr @reedwm