Fix tf.pad crashes with large paddings #51973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR tries to address the issue raised in 51908 where tf.pad crashes with large paddings. In any case, instead of a crash with undefined behavior, tensorflow should return an error gracefully. This PR fixes the issue by adding the necessary checks. This PR fixes 51908. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
gbaned
added
comp:core
mihaimaruseac
approved these changes
Oct 4, 2021
google-ml-butler
bot
added
kokoro:force-run
gbaned
approved these changes
Oct 6, 2021
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
|
Should be handled already by d81b135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address the issue raised in #51908 where
tf.pad crashes with large paddings.
In any case, instead of a crash with undefined behavior,
tensorflow should return an error gracefully.
This PR fixes the issue by adding the necessary checks.
This PR fixes #51908.
Signed-off-by: Yong Tang yong.tang.github@outlook.com