Add support of filesystem_set_configuration to tensorflow core #52316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongtang
force-pushed
the
filesystem-set_configuration
branch
9 times, most recently
from
16f40a0
to
446e847
Compare
This is a follow up to PR in tensorflow/io#1443 to add set_configuration support to tensorflow core repo. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
filesystem-set_configuration
branch
from
446e847
to
5c83ef7
Compare
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
filesystem-set_configuration
branch
from
5c83ef7
to
16ad176
Compare
yongtang
changed the title
jsimsa
approved these changes
Oct 11, 2021
google-ml-butler
bot
added
kokoro:force-run
rthadur
added
ready to pull
There was a problem hiding this comment.
Does this need to be an op? https://github.com/tensorflow/community/blob/master/rfcs/20200804-configurable-filesystems.md made it work without a kernel
|
Thanks @mihaimaruseac. One scenario of kernel ops usage is the situation where the file system has to be configured when graph is running (not pre-configure it before graph runs). In that case, I think of adding a kernel ops might be needed as otherwise the graph might not know what will be used for configuration. |
mihaimaruseac
approved these changes
Oct 13, 2021
gbaned
added
ready to pull
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
PR #52316: Add support of filesystem_set_configuration to tensorflow core Imported from GitHub PR #52316 This is a follow up to PR in tensorflow/io#1443 to add set_configuration support to tensorflow core repo. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> Copybara import of the project: -- a11f081 by Yong Tang <yong.tang.github@outlook.com>: Add support of filesystem_set_configuration to tensorflow core This is a follow up to PR in tensorflow/io#1443 to add set_configuration support to tensorflow core repo. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> -- eb8559d by Yong Tang <yong.tang.github@outlook.com>: Expose tf.experimental.filesystem_set_configuration API Signed-off-by: Yong Tang <yong.tang.github@outlook.com> -- 16ad176 by Yong Tang <yong.tang.github@outlook.com>: Add placeholder SetOption for gcs file system Signed-off-by: Yong Tang <yong.tang.github@outlook.com> PiperOrigin-RevId: 406210322 Change-Id: Ia1fd891a522c6f6a81bfab5c86c00e9940b1084a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to PR in tensorflow/io#1443 to add set_configuration support to tensorflow core repo.
Signed-off-by: Yong Tang yong.tang.github@outlook.com