-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add atrous_conv2d_transpose python function #5300
Conversation
Can one of the admins verify this patch? |
@guotong1988, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tensorflower-gardener, @keveman and @yuefengz to be potential reviewers. |
Looks nice at a high level! Let's add the tests in the same PR. |
I'm working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guotong1988 . Please make sure the test to check that both the output tensor shape and values are correct.
What's the current status here @guotong1988 ? |
I got a little busy to change my job in the past three weeks. And I just finished it. |
Nice! Ping me if you need help. |
@sbrodehl In fact I'm not sure that my only test case can cover that much . Please provide more test case, if you have. Thank you . |
I write another example , and I think my commit may be right.
|
Now that I'm sure that my commit is right , because I write this example which is similar to the above one.
|
Then I think I could start to finish the unit test. |
I tried running your code on MNIST. The output shape looks wrong to me:
gives:
I was expecting the output shape, i.e. the last line above, to read |
@Fenugreek Yes , I fixed it. |
@gpapan just sent me a full PR for implementing the transpose, btw. |
@vrv I will finish the unit test. |
@gpapan, since you wrote the internal one, I'll let you decide which one we should accept :) (based on correctness / merits, of course.) |
I nearly finish. But the code need to review and edit, of course. |
tensorflow#5300. Change: 140759688
Thank you for your code. I learn a lot. Close this PR please. |
… On Mon, Dec 5, 2016 at 12:40 AM, 郭同jet · 耐心 ***@***.***> wrote:
Thank you for your code. I learn a lot. Close this PR please.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5300 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF8Y_V16SQBnwOD5zAEWa-thMmHqWVh4ks5rE836gaJpZM4Kk04b>
.
--
Best,
George
|
Imported from GitHub PR openxla/xla#5300 This is a new GPU SPMD optimization pass for the following pattern: binary-op(all-gather(a), all-gather(b)) to all-gather(binary-op(a, b)) Copybara import of the project: -- 77aafc0686fb98a6e13b6664ee537ed3cde5e24f by kushanam <kahmadian@nvidia.com>: adding a new pass to optimize reduce_scatter->all_gather->binary_op sequence -- 0b1e8eb599f8a7334b7c9826746db67e0923f2f7 by kushanam <kahmadian@nvidia.com>: applying review refactors -- 9b181ec7487e7ded4610a779f8929d2e2a199e0d by kushanam <kahmadian@nvidia.com>: removing reduce-scatter from the all-gather optimization -- a8c49eb58f3b370627cd57c62f456696567ba60a by kushanam <kahmadian@nvidia.com>: remove traversal all-gather search and rely on immediate parent -- d90f5a148bc099455724450b84f1af8fb83ffc66 by kushanam <kahmadian@nvidia.com>: remove extra gpu word from the directive Merging this change closes #5300 PiperOrigin-RevId: 566298114
PR #5300: A new pass to optimize the AllGather->Binary_Op order sequence Imported from GitHub PR openxla/xla#5300 This is a new GPU SPMD optimization pass for the following pattern: binary-op(all-gather(a), all-gather(b)) to all-gather(binary-op(a, b)) PiperOrigin-RevId: 566340142
Imported from GitHub PR openxla/xla#5300 This is a new GPU SPMD optimization pass for the following pattern: binary-op(all-gather(a), all-gather(b)) to all-gather(binary-op(a, b)) Copybara import of the project: -- 198c4b2b8b8c155b50a5643e960366bdb51aece0 by kushanam <kahmadian@nvidia.com>: adding a new pass to optimize reduce_scatter->all_gather->binary_op sequence -- 8f8cc822229f1c6a54c969188240d5b2a421e9ee by kushanam <kahmadian@nvidia.com>: applying review refactors -- 1beffbb5ecc007aa729b2c20e39ec95a00a73fd8 by kushanam <kahmadian@nvidia.com>: removing reduce-scatter from the all-gather optimization -- 993f3d66e1a75b774e39aa3a55134f841d132df5 by kushanam <kahmadian@nvidia.com>: remove traversal all-gather search and rely on immediate parent -- c7a3bea5846220dc49ae0087039e5ad77fd308c7 by kushanam <kahmadian@nvidia.com>: remove extra gpu word from the directive -- 2b9afd129a7759ba4e59df461b9d8d06033f7649 by kushanam <kahmadian@nvidia.com>: fixing for disabled SPMD partitioning -- ee412cbbbb65f322d337dd522c17414a3c6afbd6 by kushanam <kahmadian@nvidia.com>: diferring node removal and fixing the corresponding tests Merging this change closes #5300 PiperOrigin-RevId: 569445810
Issue description : #4668
This is the first commit of the issue.
I will commit the unit test later.
I will also add the comment for the method.
Thank you for any advice.
Now I test it with:
and