Fix wrong output of tf.stack with 0-dimension tensor #53367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR tries to address the issue raised in 53300 where tf.stack will silently output wrong result with 0-dimension tensor. The issue was that the shape check was skipped when num of output elements was zero. This PR fixed the issue. This PR fixes 53300. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
53300-tf.stack
branch
from
d035b99
to
11e8165
Compare
mihaimaruseac
approved these changes
Feb 22, 2022
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 23, 2022
PiperOrigin-RevId: 430451556 Change-Id: I3ab3d17d997607c1b7727af1698bdbcde4336f8c
|
This has landed but GitHub fails to notice that. |
If it fails the detection do we need to manually close the linked issue #53300 ? |
|
@bhack Let's do that. I'll close it. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address the issue raised in #53300 where
tf.stack will silently output wrong result with 0-dimension tensor.
The issue was that the shape check was skipped when num of output elements
was zero. This PR fixed the issue.
This PR fixes #53300.
Signed-off-by: Yong Tang yong.tang.github@outlook.com