Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick fix check failures on r2.5 #53926

Merged
merged 10 commits into from
Jan 24, 2022
Merged

Cherrypick fix check failures on r2.5 #53926

merged 10 commits into from
Jan 24, 2022

Commits on Jan 17, 2022

  1. Fix bad cherrypick (1/N)

    @mihaimaruseac
    mihaimaruseac committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    84daaef View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Fix bad cherry-pick (2/N, N=2)

    @mihaimaruseac
    mihaimaruseac committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    50ba7f9 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Fixed model server crash: 

    Instead of calling the constructor of TensorShape, we call the BuildTensorShapeBase factory function and check the status of the calls in sparse_slice_op.

PiperOrigin-RevId: 402647675
Change-Id: Id9cba19c18ab0f16ea800c2b69d859935a54c2c7
    @tensorflower-gardener @mihaimaruseac
    tensorflower-gardener authored and mihaimaruseac committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    eec7866 View commit details
    Browse the repository at this point in the history

  2. Add integer overflow and negative value check for some of the op kern… 

    …els to avoid Check Failure in the InitDim called from constructor, before instantiating TensorShape.

PiperOrigin-RevId: 414610546
Change-Id: Icc713b41ef8515d2977c4c193a7bf19dd6792ffc
    @ishark @mihaimaruseac
    ishark authored and mihaimaruseac committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    77b58b4 View commit details
    Browse the repository at this point in the history

  3. Fix integer overflow error in SparseSlice op 

    PiperOrigin-RevId: 415399219
Change-Id: Ifb3cffcb5cfacb6eab151bec6b31d7a2d7f264d7
    @ishark @mihaimaruseac
    ishark authored and mihaimaruseac committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    3d3a5b1 View commit details
    Browse the repository at this point in the history

  4. Add integer overflow fixes for StringNGram, SparseSliceDataset and Sp… 

    …arseSlice ops for identified usages.

PiperOrigin-RevId: 415639495
Change-Id: Ie09094928d21e8449a372075a5e88a50c628fb04
    @ishark @mihaimaruseac
    ishark authored and mihaimaruseac committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    2904c8d View commit details
    Browse the repository at this point in the history

  5. Use SetDimWithStatus instead of set_dim. 

    This would prevent a crash due to overflow.

PiperOrigin-RevId: 416083115
Change-Id: Id2a0c11f5940ec8e28e4e39a37f506c875b5aca5
    @mihaimaruseac
    mihaimaruseac committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    8b5b53a View commit details
    Browse the repository at this point in the history

  6. Use builders for tensor shapes to prevent overflows. 

    PiperOrigin-RevId: 416083152
Change-Id: I7476345ce34039bde8afa657412ff0b7b64b03d9
    @mihaimaruseac
    mihaimaruseac committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    f914289 View commit details
    Browse the repository at this point in the history

  7. Prevent overflow causing crash in SerializeManySparse 

    PiperOrigin-RevId: 416083201
Change-Id: Ib5244a92ea4e84a1af5e7f3339e6876a88a533a7
    @mihaimaruseac
    mihaimaruseac committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    faf7c38 View commit details
    Browse the repository at this point in the history

  8. Add a fix for Check Failure due to integer overflow 

    PiperOrigin-RevId: 416216408
Change-Id: I16d3e2ce35d88b91e8a4ca38b9ebbbf7a05ee792
    @ishark @mihaimaruseac
    ishark authored and mihaimaruseac committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    9fdd1b6 View commit details
    Browse the repository at this point in the history