Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump ICU to 69.1 to handle CVE-2020-10531." #54188

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 3 additions & 22 deletions third_party/icu/data/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -19,28 +19,9 @@ exports_files(["LICENSE"])
# $ ICU_DATA_FILTER_FILE=filters.json ./runConfigureICU Linux
# $ make clean && make
# $ cd data/out/tmp
# $ genccode icudt70l.dat # Note: this number must match version, and below too!
# $ echo 'U_CAPI const void * U_EXPORT2 uprv_getICUData_conversion() { return icudt70l_dat.bytes; }' >> icudt70l_dat.c
#
# This creates icudt70l_dat.c, which you can move, rename, gzip, then split,
# for example (but you can change to other numbers):
# $ cp icudt70l_dat.c icu_conversion_data.c
# $ gzip icu_conversion_data.c
# # Note: make sure you don't forget the last . below!
# $ split -a 3 -b 100000 icu_conversion_data.c.gz icu_conversion_data.c.gz.
#
# Then, copy the generated files to this directory, removing existing ones.
#
# The current files have been generated by this filter (in filters.json):
# {
# "localeFilter": {
# "filterType": "language",
# "includelist": [
# "en"
# ]
# }
# }
# Please make sure to keep this updated if you change the data files.
# $ genccode icudt64l.dat
# $ echo 'U_CAPI const void * U_EXPORT2 uprv_getICUData_conversion() { return icudt64l_dat.bytes; }' >> icudt64l_dat.c
# This creates icudt64l_dat.c, which you can move, rename, gzip, then split.
filegroup(
name = "conversion_files",
srcs = glob(["icu_conversion_data.c.gz.*"]),
Expand Down
Binary file added third_party/icu/data/icu_conversion_data.c.gz.aa
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aaa
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aab
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aac
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aad
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aae
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aaf
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aag
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aah
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aai
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aaj
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aak
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aal
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aam
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aan
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aao
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aap
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aaq
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aar
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aas
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aat
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aau
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aav
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aaw
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aax
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aay
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aaz
Binary file not shown.
Binary file added third_party/icu/data/icu_conversion_data.c.gz.ab
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aba
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abb
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abc
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abd
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abe
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abf
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abg
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abh
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abi
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abj
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abk
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abl
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abm
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abn
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abo
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abp
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abq
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abr
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abs
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abt
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abu
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abv
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abw
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abx
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aby
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.abz
Binary file not shown.
Binary file added third_party/icu/data/icu_conversion_data.c.gz.ac
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aca
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acb
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acc
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acd
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.ace
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acf
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acg
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.ach
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aci
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acj
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.ack
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acl
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acm
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acn
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.aco
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acp
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acq
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acr
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acs
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.act
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acu
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acv
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acw
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acx
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acy
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.acz
Binary file not shown.
Binary file added third_party/icu/data/icu_conversion_data.c.gz.ad
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.ada
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.adb
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.adc
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.add
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.ade
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.adf
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.adg
Binary file not shown.
Binary file removed third_party/icu/data/icu_conversion_data.c.gz.adh
Binary file not shown.
Binary file added third_party/icu/data/icu_conversion_data.c.gz.ae
Binary file not shown.
Binary file added third_party/icu/data/icu_conversion_data.c.gz.af
Binary file not shown.
Binary file added third_party/icu/data/icu_conversion_data.c.gz.ag
Binary file not shown.
Binary file added third_party/icu/data/icu_conversion_data.c.gz.ah
Binary file not shown.
Binary file added third_party/icu/data/icu_conversion_data.c.gz.ai
Binary file not shown.
Binary file added third_party/icu/data/icu_conversion_data.c.gz.aj
Binary file not shown.
3 changes: 1 addition & 2 deletions third_party/icu/udata.patch
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ diff -ru a/icu4c/source/common/udata.cpp b/icu4c/source/common/udata.cpp
}
- */
+
#if !defined(ICU_DATA_DIR_WINDOWS)
// When using the Windows system data, we expect only a single data file.
#if U_PLATFORM_HAS_WINUWP_API == 0 // Windows UWP Platform does not support dll icu data at this time
setCommonICUDataPointer(&U_ICUDATA_ENTRY_POINT, FALSE, pErrorCode);
{
diff -ru a/icu4c/source/common/unicode/uconfig.h b/icu4c/source/common/unicode/uconfig.h
Expand Down
13 changes: 7 additions & 6 deletions third_party/icu/workspace.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@

load("//third_party:repo.bzl", "tf_http_archive")

# NOTE: If you upgrade this, generate the data files by following the
# instructions in third_party/icu/data/BUILD
def repo():
tf_http_archive(
name = "icu",
strip_prefix = "icu-release-69-1",
sha256 = "3144e17a612dda145aa0e4acb3caa27a5dae4e26edced64bc351c43d5004af53",
urls = tf_mirror_urls("https://github.com/unicode-org/icu/archive/release-69-1.zip"),
build_file = "//third_party/icu:icu.BUILD",
strip_prefix = "icu-release-64-2",
sha256 = "dfc62618aa4bd3ca14a3df548cd65fe393155edd213e49c39f3a30ccd618fc27",
urls = [
"https://storage.googleapis.com/mirror.tensorflow.org/github.com/unicode-org/icu/archive/release-64-2.zip",
"https://github.com/unicode-org/icu/archive/release-64-2.zip",
],
build_file = "//third_party/icu:BUILD.bazel",
system_build_file = "//third_party/icu:BUILD.system",
patch_file = "//third_party/icu:udata.patch",
)