Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix msvc build break on non en-US codepage (#53219) #54377

Merged
merged 3 commits into from
Apr 15, 2022
Merged

fix msvc build break on non en-US codepage (#53219) #54377

merged 3 commits into from
Apr 15, 2022

Conversation

fo40225
Copy link
Contributor

@fo40225 fo40225 commented Feb 14, 2022

#53219 it's not complete.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Feb 14, 2022
@tilakrayal tilakrayal added the comp:lite TF Lite related issues label Feb 15, 2022
@tilakrayal tilakrayal added this to Assigned Reviewer in PR Queue via automation Feb 15, 2022
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Feb 15, 2022
@tilakrayal tilakrayal self-assigned this Feb 15, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 15, 2022
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Feb 15, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 15, 2022
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Feb 17, 2022
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Feb 20, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 20, 2022
karimnosseir
karimnosseir suggested changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@karimnosseir karimnosseir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is failing test. You need to update the test here
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/python/analyzer_test.py#L183

PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Feb 23, 2022
@tilakrayal tilakrayal removed their assignment Feb 23, 2022
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Feb 24, 2022
@fo40225 fo40225 force-pushed the fix-C2001 branch 3 times, most recently from 7c09d73 to 639a7fc Compare February 24, 2022 13:25
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Mar 1, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 1, 2022
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Mar 1, 2022
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Mar 1, 2022
@gbaned gbaned added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 2, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 2, 2022
@gbaned gbaned removed the ready to pull PR ready for merge process label Mar 4, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 4, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 4, 2022
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Mar 4, 2022
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Mar 22, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 23, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 23, 2022
@copybara-service copybara-service bot merged commit d1ae20f into tensorflow:master Apr 15, 2022
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Apr 15, 2022
@mihaimaruseac mihaimaruseac mentioned this pull request Apr 15, 2022
Open
@rthadur rthadur mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@karimnosseir karimnosseir karimnosseir approved these changes

@gbaned gbaned gbaned approved these changes

Assignees

@gbaned gbaned

Labels
comp:lite TF Lite related issues size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Approved by Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@fo40225 @mihaimaruseac @karimnosseir @gbaned @kokoro-team @tensorflowbutler @rthadur @tilakrayal