Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add complex support for tf.math.atan #54426

Closed
wants to merge 3 commits into from
Closed

Add complex support for tf.math.atan #54426

wants to merge 3 commits into from
+4 −2

Conversation

rthadur
Copy link
Contributor

@rthadur rthadur commented Feb 17, 2022

Fixes #54411

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Feb 17, 2022
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Feb 17, 2022
mihaimaruseac
mihaimaruseac requested changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add tests

tensorflow/core/kernels/cwise_op_atan.cc Outdated Show resolved Hide resolved
mihaimaruseac
mihaimaruseac approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(my bad, just noticed second file is a test file, not a glue link)

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 17, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 17, 2022
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Feb 18, 2022
@gbaned gbaned added the prtype:bugfix PR to fix a bug label Feb 18, 2022
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Feb 18, 2022
@gbaned gbaned removed the awaiting review Pull request awaiting review label Feb 18, 2022
copybara-service bot pushed a commit that referenced this pull request Feb 18, 2022
@tensorflower-gardener
Merge pull request #54426 from rthadur:master
64af5cd 
PiperOrigin-RevId: 429565662
Change-Id: I806ea12acaa4cd5abba7706a893b65e374cc3776
@rthadur
Copy link
Contributor Author

rthadur commented Feb 18, 2022

Seems auto-merge is not happening but the changes are now committed.

@rthadur rthadur closed this Feb 18, 2022
PR Queue automation moved this from Assigned Reviewer to Closed/Rejected Feb 18, 2022
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Feb 18, 2022
copybara-service bot pushed a commit that referenced this pull request Feb 18, 2022
@tensorflower-gardener
Rollback of PR #54426
ef14b5b 
PiperOrigin-RevId: 429588528
Change-Id: Iabd777b197bfde7fe75835362c1b57ca5b9a4bef
@github-actions github-actions bot mentioned this pull request Feb 18, 2022
Closed
@bhack bhack mentioned this pull request Apr 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees

@gbaned gbaned

Labels
prtype:bugfix PR to fix a bug size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Closed/Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tf.math.atan lack support for complex64
4 participants
@rthadur @mihaimaruseac @kokoro-team @gbaned