[mhlo] Clean up C-API references to CPP #55888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't find the error message in error log, Did infa problem? |
joker-eph
reviewed
May 4, 2022
joker-eph
approved these changes
May 6, 2022
google-ml-butler
bot
added
kokoro:force-run
copybara-service bot
pushed a commit
to tensorflow/mlir-hlo
that referenced
this pull request
May 9, 2022
Imported from GitHub PR tensorflow/tensorflow#55888 remove std::string referencres in ```tensorflow/compiler/mlir/hlo/include/mlir-hlo-c/Attributes.h``` file. Copybara import of the project: -- 79e4773aee3a5c09814b3d349f92324bc7898f49 by lipracer <lipracer@gmail.com>: [mhlo] Clean up C-API references to CPP -- 7fad8c409cda3f50284d1f487cfa2da496798597 by lipracer <lipracer@gmail.com>: [mhlo] replace const char* with MlirStringRef Merging this change closes #55888 PiperOrigin-RevId: 447594137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove std::string referencres in
tensorflow/compiler/mlir/hlo/include/mlir-hlo-c/Attributes.hfile.