Add upper bound to protobuf in setup.py. #56199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also: #53234 See also: protocolbuffers/protobuf#9954 See also: #56077 PiperOrigin-RevId: 450054200
mihaimaruseac
requested changes
May 20, 2022
Comment on lines
+92
to
+99
| # TODO(b/182876485): Protobuf 3.20 results in linker errors on Windows | ||
| # Protobuf 4.0 is binary incompatible with what C++ TF uses. | ||
| # We need ~1 quarter to update properly. | ||
| # See also: https://github.com/tensorflow/tensorflow/issues/53234 | ||
| # See also: https://github.com/protocolbuffers/protobuf/issues/9954 | ||
| # See also: https://github.com/tensorflow/tensorflow/issues/56077 | ||
| # This is a temporary patch for now, to patch previous TF releases. | ||
| 'protobuf >= 3.9.2, < 3.20', |
There was a problem hiding this comment.
You only need these lines to be added
| 'h5py ~= 3.1.0', | ||
| 'keras_preprocessing ~= 1.1.2', | ||
| 'opt_einsum ~= 3.3.0', | ||
| 'protobuf >= 3.9.2', |
There was a problem hiding this comment.
And you only need this line to be removed
|
Replacing with #56200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #53234
See also: protocolbuffers/protobuf#9954
See also: #56077
PiperOrigin-RevId: 450054200