Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneDNN] Skip appending kernel registration to log message for MKL ops #57137

Closed

Conversation

kanvi-nervana
Copy link
Contributor

@kanvi-nervana kanvi-nervana commented Aug 12, 2022

This PR skips printing kernel registrations for MKL ops since it leads to performance drop for some eager models caused by this commit c04f65d This is a temporary fix and the condition will be removed when support for block format is removed as a more permanent fix.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Aug 12, 2022
@github-actions github-actions bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 12, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 12, 2022
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Aug 12, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 12, 2022
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 13, 2022
@gbaned gbaned added the comp:core issues related to core part of tensorflow label Aug 13, 2022
PR Queue automation moved this from Assigned Reviewer to Closed/Rejected Aug 13, 2022
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:core issues related to core part of tensorflow size:S CL Change Size: Small
Projects
PR Queue
  
Closed/Rejected
Development

Successfully merging this pull request may close these issues.

None yet

4 participants