558: Markdown to html, titles #575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
As @martinwicke mentioned in #558, this change has to be made internally in our website generation code. |
darkbuck
pushed a commit
to darkbuck/tensorflow
that referenced
this pull request
Jan 23, 2020
…pstream-sync-190722 Develop upstream sync 190722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Most of projects I have worked on were based on Jekyll, pigments of markdown to webpages and used title/layout based on .yml/css/layouts file.In other python projects, providing title on the link itself works.Both variants done as example on Contributing.md to seek inputs.thanks.
However as this largely depends on project .js/.css files, from my quick look on this codebase, seems the tensorflow/python/framework/docs.py the .md content just gets transformed to body content, and likely library.title reflects the title of page.thanks.