Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FindFlatBuffers cmake file #58677

Merged
merged 1 commit into from Feb 22, 2023
Merged

Fix FindFlatBuffers cmake file #58677

merged 1 commit into from Feb 22, 2023

Conversation

jameshilliard
Copy link
Contributor

Capitalization needs to match for system cmake override to work:
https://github.com/google/flatbuffers/blob/v22.11.23/CMake/FindFlatBuffers.cmake

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Nov 24, 2022
@gbaned gbaned added the comp:lite TF Lite related issues label Nov 25, 2022
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Nov 25, 2022
@gbaned gbaned requested a review from terryheo November 25, 2022 11:13
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Nov 25, 2022
@jameshilliard jameshilliard force-pushed the fix-find-flatbuffers branch 2 times, most recently from eb10b21 to d8f98dd Compare November 27, 2022 18:48
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Dec 29, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 29, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 29, 2022
@jameshilliard
Copy link
Contributor Author

Anything holding this up from being merged? I see a Google internal checks FAILED for runs with create time 2022-12-30T01:04:31.307953960Z. test failure but there aren't any failure details visible.

@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jan 6, 2023
@gbaned gbaned added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Jan 17, 2023
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jan 25, 2023
@gbaned gbaned added ready to pull PR ready for merge process kokoro:force-run Tests on submitted change and removed ready to pull PR ready for merge process labels Feb 9, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 14, 2023
@copybara-service copybara-service bot merged commit 53129b8 into tensorflow:master Feb 22, 2023
PR Queue automation moved this from Approved by Reviewer to Merged Feb 22, 2023
@jameshilliard jameshilliard deleted the fix-find-flatbuffers branch February 22, 2023 10:17
daniel-lang added a commit to daniel-lang/tensorflow that referenced this pull request Jul 26, 2023
@daniel-lang
[TFLite] Fix FlatBuffers package name in installed CMake files
f9d4231 
Similiar to tensorflow#58677, the capitalization of FlatBuffers needs to match.
Otherwise using TFLite via find_package() will fail to find FlatBuffers.
@daniel-lang daniel-lang mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@terryheo terryheo Awaiting requested review from terryheo

Assignees

@gbaned gbaned

Labels
comp:lite TF Lite related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jameshilliard @mihaimaruseac @kokoro-team @gbaned