[NVIDIA TF] Throw error only for non-empty function definitions. #59619
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reedwm what do you think ? |
pjannaty
changed the title
|
Thanks for the PR! Quick question,
When does this happen? |
|
@k-w-w we tried to register an OP that can define or not an optional |
|
I see, can you add this as a comment in the code? ( |
pavanimajety
force-pushed
the
funcdef2graphdef_emptyfuncs
branch
from
0800f36
to
891f6fe
Compare
Add reason for the required change. Add comment to both locations.
pavanimajety
force-pushed
the
funcdef2graphdef_emptyfuncs
branch
from
891f6fe
to
e0fe60f
Compare
google-ml-butler
bot
added
kokoro:force-run
google-ml-butler
bot
removed
awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Function Serialization and Deserialization with Saved Models there can be Node ops with type
funcwith default values that have no associated name. In such cases, we shouldn't look for undefined empty strings in Function Library. This is a trivial change and helps with how Saved Models are loaded.