Fix tensor_or_memref build error without math.h #59775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedwm
approved these changes
Feb 22, 2023
google-ml-butler
bot
added
kokoro:force-run
|
Thanks for the fix! |
copybara-service bot
pushed a commit
to tensorflow/mlir-hlo
that referenced
this pull request
Feb 23, 2023
Imported from GitHub PR tensorflow/tensorflow#59775 tensorflow/tensorflow#59536 (comment) Since pevious PR has been rolled back, this one adopted reviewer's feedback to fix Mac build error. Thanks @reedwm for the feedback and suggestion! Copybara import of the project: -- 4f9f856e0159f5dd7c4e8d0e3b5232e55795f700 by Chao Chen <cchen104@amd.com>: fix tensor_or_memref build error without math.h Merging this change closes #59775 PiperOrigin-RevId: 511716904
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Feb 23, 2023
Imported from GitHub PR tensorflow/tensorflow#59775 tensorflow/tensorflow#59536 (comment) Since pevious PR has been rolled back, this one adopted reviewer's feedback to fix Mac build error. Thanks @reedwm for the feedback and suggestion! Copybara import of the project: -- 4f9f856e0159f5dd7c4e8d0e3b5232e55795f700 by Chao Chen <cchen104@amd.com>: fix tensor_or_memref build error without math.h Merging this change closes #59775 PiperOrigin-RevId: 511716904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#59536 (comment)
Since pevious PR has been rolled back, this one adopted reviewer's feedback to fix Mac build error.
Thanks @reedwm for the feedback and suggestion!