-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing floor operation #60317
base: master
Are you sure you want to change the base?
add missing floor operation #60317
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @alankelly Can you please review this PR ? Thank you! |
2 similar comments
Hi @alankelly Can you please review this PR ? Thank you! |
Hi @alankelly Can you please review this PR ? Thank you! |
@terryheo can you please take a look at this? |
Hi @terryheo, Can you please review this PR ? Thank you! |
Hi @sirakiin Can you please review this PR ? Thank you! |
3 similar comments
Hi @sirakiin Can you please review this PR ? Thank you! |
Hi @sirakiin Can you please review this PR ? Thank you! |
Hi @sirakiin Can you please review this PR ? Thank you! |
Please add corresponding tests in tensorflow/lite/delegates/gpu/cl/kernels/elementwise_test.cc and tensorflow/lite/delegates/gpu/gl/kernels/elementwise_test.cc. Thanks! |
Hi @jeandsp Any update on this PR? Please. Thank you! |
Currently, the "FLOOR" operation is not properly supported on the GPU delegate. The underlying opencl/opengl implementation exists but the operation type is missing in operation_selector.cc, which prevents from using the floor op.