Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing floor operation #60317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeandsp
Copy link

@jeandsp jeandsp commented Apr 13, 2023

Currently, the "FLOOR" operation is not properly supported on the GPU delegate. The underlying opencl/opengl implementation exists but the operation type is missing in operation_selector.cc, which prevents from using the floor op.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Apr 13, 2023
@google-cla
Copy link

google-cla bot commented Apr 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gbaned gbaned added the comp:lite TF Lite related issues label Apr 14, 2023
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 14, 2023
@gbaned gbaned requested a review from alankelly April 14, 2023 06:28
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Apr 14, 2023
@gbaned
Copy link
Contributor

gbaned commented May 5, 2023

Hi @alankelly Can you please review this PR ? Thank you!

2 similar comments
@gbaned
Copy link
Contributor

gbaned commented Jul 12, 2023

Hi @alankelly Can you please review this PR ? Thank you!

@gbaned
Copy link
Contributor

gbaned commented Sep 1, 2023

Hi @alankelly Can you please review this PR ? Thank you!

@alankelly
Copy link
Contributor

@terryheo can you please take a look at this?

@alankelly alankelly requested review from terryheo and removed request for alankelly September 4, 2023 12:32
@gbaned
Copy link
Contributor

gbaned commented Nov 3, 2023

Hi @terryheo, Can you please review this PR ? Thank you!

@gbaned gbaned requested a review from sirakiin December 22, 2023 06:49
@gbaned
Copy link
Contributor

gbaned commented Dec 29, 2023

Hi @sirakiin Can you please review this PR ? Thank you!

3 similar comments
@gbaned
Copy link
Contributor

gbaned commented Jan 19, 2024

Hi @sirakiin Can you please review this PR ? Thank you!

@gbaned
Copy link
Contributor

gbaned commented Mar 8, 2024

Hi @sirakiin Can you please review this PR ? Thank you!

@gbaned
Copy link
Contributor

gbaned commented Apr 26, 2024

Hi @sirakiin Can you please review this PR ? Thank you!

@sirakiin
Copy link
Member

Please add corresponding tests in tensorflow/lite/delegates/gpu/cl/kernels/elementwise_test.cc and tensorflow/lite/delegates/gpu/gl/kernels/elementwise_test.cc. Thanks!

@gbaned
Copy link
Contributor

gbaned commented May 29, 2024

Hi @jeandsp Can you please check @sirakiin's comments and keep us posted ? Thank you!

@gbaned gbaned added stat:awaiting response Status - Awaiting response from author and removed awaiting review Pull request awaiting review labels May 29, 2024
@gbaned
Copy link
Contributor

gbaned commented Jun 7, 2024

Hi @jeandsp Any update on this PR? Please. Thank you!

@google-ml-butler google-ml-butler bot removed the stat:awaiting response Status - Awaiting response from author label Jun 7, 2024
@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:lite TF Lite related issues size:XS CL Change Size: Extra Small stat:awaiting response Status - Awaiting response from author
Projects
PR Queue
  
Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

4 participants