Pin Python dependency versions #60491
Conversation
| astunparse ~= 1.6.3 | ||
| flatbuffers ~= 23.1.21 | ||
| flatbuffers == 23.3.3 | ||
| google_pasta ~= 0.2 | ||
| h5py ~= 3.8.0 # Earliest version for Python 3.11 | ||
| # TODO(b/262592253): Support older versions of NumPy for Python 3.10 and lower | ||
| # to support TFX. Remove when Apache Beam upgrades to newer NumPy. | ||
| numpy ~= 1.22.0; python_version < '3.11' |
There was a problem hiding this comment.
Need to change this to ==
There was a problem hiding this comment.
You need to change the above numpy too. The above should be 1.22.4, the below should probably be 1.23.2
There was a problem hiding this comment.
Still need to change this numpy.
| astunparse ~= 1.6.3 | ||
| flatbuffers ~= 2.0 | ||
| flatbuffers == 23.3.3 | ||
| google_pasta ~= 0.2 | ||
| h5py ~= 3.8.0 # Earliest version for Python 3.11 | ||
| # TODO(b/262592253): Support older versions of NumPy for Python 3.10 and lower | ||
| # to support TFX. Remove when Apache Beam upgrades to newer NumPy. | ||
| numpy ~= 1.22.0; python_version < '3.11' |
There was a problem hiding this comment.
Still need to handle this numpy
tensorflow/tools/tf_sig_build_dockerfiles/devel.requirements.txt
Outdated
Show resolved
Hide resolved
tensorflow/tools/tf_sig_build_dockerfiles/devel.requirements.txt
Outdated
Show resolved
Hide resolved
venkat2469
requested review from
mihaimaruseac,
geetachavan1,
learning-to-play and
rishikasinha-tf
and removed request for
geetachavan1
There was a problem hiding this comment.
Don't forget the other files in the directories too. E.g., https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/ci_build/release/requirements_mac.txt
| astunparse ~= 1.6.3 | ||
| flatbuffers ~= 23.1.21 | ||
| flatbuffers == 23.3.3 | ||
| google_pasta ~= 0.2 | ||
| h5py ~= 3.8.0 # Earliest version for Python 3.11 | ||
| # TODO(b/262592253): Support older versions of NumPy for Python 3.10 and lower | ||
| # to support TFX. Remove when Apache Beam upgrades to newer NumPy. | ||
| numpy ~= 1.22.0; python_version < '3.11' |
There was a problem hiding this comment.
You need to change the above numpy too. The above should be 1.22.4, the below should probably be 1.23.2
| astunparse ~= 1.6.3 | ||
| flatbuffers ~= 23.1.21 | ||
| flatbuffers == 23.3.3 | ||
| google_pasta ~= 0.2 | ||
| h5py ~= 3.8.0 # Earliest version for Python 3.11 | ||
| # TODO(b/262592253): Support older versions of NumPy for Python 3.10 and lower | ||
| # to support TFX. Remove when Apache Beam upgrades to newer NumPy. | ||
| numpy ~= 1.22.0; python_version < '3.11' |
There was a problem hiding this comment.
Still need to change this numpy.
| scipy ~= 1.7.2; python_version < '3.11' | ||
| grpcio == 1.49.1 # Earliest version for Python 3.11 | ||
| portpicker == 1.4.0 | ||
| scipy == 1.7.3; python_version < '3.11' | ||
| scipy ~= 1.9.2; python_version >= '3.11' # Earliest version for Python 3.11 |
There was a problem hiding this comment.
Don't forget about this scipy
| <<<<<<< HEAD | ||
| scipy ~= 1.7.3; python_version < '3.11' | ||
| ======= | ||
| scipy == 1.7.3; python_version < '3.11' | ||
| >>>>>>> refs/remotes/origin/venkat-patch-12 |
There was a problem hiding this comment.
This has conflict markers
| @@ -4,9 +4,9 @@ | |||
| certifi ~= 2022.12.07 | |||
There was a problem hiding this comment.
This also needs to change
| astunparse ~= 1.6.3 | ||
| flatbuffers ~= 2.0 | ||
| flatbuffers == 23.3.3 | ||
| google_pasta ~= 0.2 | ||
| h5py ~= 3.8.0 # Earliest version for Python 3.11 | ||
| # TODO(b/262592253): Support older versions of NumPy for Python 3.10 and lower | ||
| # to support TFX. Remove when Apache Beam upgrades to newer NumPy. | ||
| numpy ~= 1.22.0; python_version < '3.11' |
There was a problem hiding this comment.
Still need to handle this numpy
| scipy ~= 1.7.2; python_version < '3.11' | ||
| grpcio == 1.49.1 # Earliest version for Python 3.11 | ||
| portpicker == 1.4.0 | ||
| scipy == 1.7.3; python_version < '3.11' | ||
| scipy ~= 1.9.2; python_version >= '3.11' # Earliest version for Python 3.11 |
There was a problem hiding this comment.
Don't forget about this scipy
| jax ~= 0.3.24 | ||
| jaxlib ~= 0.3.24 # Earliest version for Python 3.11 | ||
| jax == 0.3.25 | ||
| jaxlib == 0.3.25 # Earliest version for Python 3.11 | ||
| # Needs to be addressed. Unblocked 2.4 branchcut cl/338377048 | ||
| PyYAML ~= 6.0 |
| jax ~= 0.3.24 | ||
| jaxlib ~= 0.3.24 # Earliest version for Python 3.11 | ||
| jax == 0.3.25 | ||
| jaxlib == 0.3.25 # Earliest version for Python 3.11 | ||
| # Needs to be addressed. Unblocked 2.4 branchcut cl/338377048 | ||
| PyYAML ~= 6.0 | ||
| # For uploading | ||
| auditwheel ~= 5.0.0 |
| lxml ~= 4.9.1 | ||
| pylint ~= 2.13.9 |
| typing_extensions ~= 3.10.0.0 | ||
| wheel ~= 0.38.1 | ||
| wrapt ~= 1.14.1 | ||
| numpy ~= 1.22.4; python_version < '3.11' |
| h5py ~= 3.8.0 # Earliest version for Python 3.11 | ||
| absl-py == 1.0.0 | ||
| astunparse == 1.6.3 | ||
| flatbuffers == 23.1.21 |
There was a problem hiding this comment.
This seems wrong. From 2.0 to 23.1.21?
There was a problem hiding this comment.
so can i use the same 2.0 ?
There was a problem hiding this comment.
This is the history for flatbuffers. https://github.com/tensorflow/tensorflow/commits/master/tensorflow/tools/ci_build/release/requirements_common.txt
There was a problem hiding this comment.
You have to use the python wheel version number
There was a problem hiding this comment.
As for what number to use, you have to see what gets installed in the build log for the last nightly and use that one
No description provided.