Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 tooling / CI support #62155

Closed
wants to merge 2 commits into from

Conversation

SamuelMarks
Copy link
Contributor

I saw 5f7f05a so I guess we're close to Python 3.12 support. Committing this up so I can see what passes/fails and fix accordingly.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Oct 18, 2023
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 18, 2023
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Oct 18, 2023
@MichaelHudgins
Copy link
Collaborator

@vladbelit could you PTAL

.github/workflows/arm-cd.yml Outdated Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Oct 19, 2023
@vladbelit
Copy link

We have a similar change going out soon (nightly jobs), though there are still a couple of details being hashed out with regards to CI

@mihaimaruseac mihaimaruseac mentioned this pull request Oct 22, 2023
8 tasks
@gbaned
Copy link
Contributor

gbaned commented Nov 3, 2023

Hi @SamuelMarks Can you please rebase your branch and resolve conflicts? Thank you!

@gbaned gbaned added stat:awaiting response Status - Awaiting response from author and removed awaiting review Pull request awaiting review labels Nov 3, 2023
@vladbelit
Copy link

This could probably be closed - the Linux x86/ARM 3.12 nightlies are up. They should soon be set to upload, once a few superficial test failures are resolved.
MacOS should be added soon as well.

@google-ml-butler google-ml-butler bot removed the stat:awaiting response Status - Awaiting response from author label Nov 3, 2023
@MichaelHudgins
Copy link
Collaborator

Thanks for the PR @SamuelMarks but the internal effort landed and our continued development of the official directory would have needed this PR to change multiple times.

PR Queue automation moved this from Reviewer Requested Changes to Closed/Rejected Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M CL Change Size: Medium
Projects
PR Queue
  
Closed/Rejected
Development

Successfully merging this pull request may close these issues.

None yet

4 participants