Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include missing tsl/xla folders on Windows #62874

Conversation

mraunak
Copy link
Contributor

@mraunak mraunak commented Jan 30, 2024

This PR aims to resolve the issue of the missing TSL and XLA folders within the 'include' directory in the TF release and nightly wheels specifically for the Windows platform. The folders are present for the Linux platform

It addresses the Github issues mentioned below:
#62579
#61830

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jan 30, 2024
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 30, 2024
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Jan 30, 2024
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jan 31, 2024
@copybara-service copybara-service bot merged commit 056c36e into tensorflow:master Jan 31, 2024
12 of 13 checks passed
PR Queue automation moved this from Assigned Reviewer to Merged Jan 31, 2024
copybara-service bot pushed a commit that referenced this pull request Feb 1, 2024
@karllessard
Copy link
Contributor

@mraunak , about #62579 , it looks like the nightly build still have the problem, even after merging this PR. What is missing is not folder in this case but symbols exported by the C library:

jnitensorflow.obj : error LNK2001: unresolved external symbol TSL_DeleteStatus
jnitensorflow.obj : error LNK2001: unresolved external symbol TSL_SetStatus
jnitensorflow.obj : error LNK2001: unresolved external symbol TSL_SetStatusFromIOError
jnitensorflow.obj : error LNK2001: unresolved external symbol "struct TFE_TensorHandle * __cdecl TFE_NewTensorHandle(class tensorflow::Tensor const &,struct TSL_Status *)" (?TFE_NewTensorHandle@@YAPEAUTFE_TensorHandle@@AEBVTensor@tensorflow@@PEAUTSL_Status@@@Z)
  Hint on symbols that are defined and could potentially match:
    TFE_NewTensorHandle
jnitensorflow.obj : error LNK2001: unresolved external symbol TSL_Message
jnitensorflow.obj : error LNK2001: unresolved external symbol TSL_ForEachPayload
jnitensorflow.obj : error LNK2001: unresolved external symbol TSL_NewStatus
jnitensorflow.obj : error LNK2001: unresolved external symbol TSL_GetCode
jnitensorflow.obj : error LNK2001: unresolved external symbol TSL_SetPayload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants