Fix checkfail with -ve perm values in transpose_op.cc #63064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing negative values to argument perm in tf.raw_ops.Transpose will cause checkfail and coredump error. Hence validation proposed to check and raise exception. Ref issue #62995
gbaned
added
prtype:bugfix
sagunb
requested changes
Feb 28, 2024
Updated as suggested to adhere c++ standard
|
Hi @SuryanarayanaY Can you please check @mihaimaruseac's comments ? Thank you! |
gbaned
added
stat:awaiting response
Local variable created outside loop.
|
Done the changes proposed. |
google-ml-butler
bot
removed
the
stat:awaiting response
google-ml-butler
bot
added
kokoro:force-run
mihaimaruseac
requested changes
Mar 6, 2024
Updated TF error wrapper with absl
mihaimaruseac
approved these changes
Mar 8, 2024
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
mihaimaruseac
requested changes
Mar 18, 2024
Replaced if check with OP_REQUIRES as the function is void type.
mihaimaruseac
requested changes
Mar 19, 2024
mihaimaruseac
approved these changes
Mar 19, 2024
google-ml-butler
bot
added
kokoro:force-run
mihaimaruseac
requested changes
Mar 20, 2024
|
Hi @SuryanarayanaY Can you please check @mihaimaruseac's comments ? Thank you! |
gbaned
added
stat:awaiting response
mihaimaruseac
approved these changes
Apr 18, 2024
google-ml-butler
bot
added
kokoro:force-run
|
This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you. |
github-actions
bot
added
the
stale
|
Not stale. The PR has been amended. |
google-ml-butler
bot
removed
stale
|
Not changed since last approval. It still fails internally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing negative values to argument perm in tf.raw_ops.Transpose will cause checkfail and coredump error. Hence validation proposed to check and raise exception.
Ref issue #62995