PR #11444: [XLA:GPU] disable mask in cuDNN attention #65512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Imported from GitHub PR openxla/xla#11444 1. cuDNN attention mask is not doing masking with -inf but multiply which is not correct. Hence disable patterns with mask. 2. Follow up PR to clean up the remaining mask related logic. Copybara import of the project: -- acf95b6cc7e1084026eaf87c0119ba3801ba8f8c by cjkkkk <ske@nvidia.com>: disable mask Merging this change closes #11444 PiperOrigin-RevId: 624068883
copybara-service
bot
force-pushed
the
exported_pr_624057479
branch
from
3b20da8
to
acc703a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #11444: [XLA:GPU] disable mask in cuDNN attention
Imported from GitHub PR openxla/xla#11444
Copybara import of the project:
--
acf95b6cc7e1084026eaf87c0119ba3801ba8f8c by cjkkkk ske@nvidia.com:
disable mask
Merging this change closes #11444
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11444 from Cjkkkk:remove_mask acf95b6cc7e1084026eaf87c0119ba3801ba8f8c