[oneDNN] QuantizeV2 with bfloat16 Input #66085
Open
+247
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-ml-butler
bot
added
awaiting review
|
Hi @penpornk Can you please review this PR ? Thank you! |
cantonios
requested changes
Apr 29, 2024
|
@cantonios Thanks for reviewing this PR. I have addressed the comments. Please check. |
cantonios
approved these changes
Apr 30, 2024
google-ml-butler
bot
added
kokoro:force-run
cantonios
approved these changes
May 3, 2024
cantonios
approved these changes
May 13, 2024
google-ml-butler
bot
added
kokoro:force-run
cantonios
reviewed
May 13, 2024
| @@ -21,30 +21,48 @@ limitations under the License. | |||
| #include "tensorflow/core/kernels/ops_testutil.h" | |||
| #include "tensorflow/core/kernels/ops_util.h" | |||
| #include "tensorflow/core/lib/core/status_test_util.h" | |||
| #include "tensorflow/core/lib/gtl/array_slice.h" | |||
There was a problem hiding this comment.
tensorflow/core/kernels/quantize_op_test.cc:24:10: error: module //tensorflow/core/kernels:quantize_op_test does not depend on a module exporting 'tensorflow/core/lib/gtl/array_slice.h'
24 | #include "tensorflow/core/lib/gtl/array_slice.h"
There was a problem hiding this comment.
Fixed it now. Thanks!
cantonios
requested changes
May 13, 2024
cantonios
approved these changes
May 14, 2024
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
|
@cantonios Is there any other issues with this PR? |
gbaned
added
ready to pull
gbaned
added
ready to pull
keerthanakadiri
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopened the closed PR: #56613
This PR depends on #66082
It extends QuantizeV2 op for converting bfloat16 tensor to quantized tensor. It helps quantizing a model with bfloat16 and 8-bit integer mixed precisions, for example using Intel Neural Compressor (INC) tool (https://github.com/intel/neural-compressor).