Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneDNN] Quantized batch-matmul and fusions #66934

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mdfaijul
Copy link
Contributor

@mdfaijul mdfaijul commented May 3, 2024

Reopened the rollback cd6c5aa

This PR enables support for quantized batched matrices in the BatchMatMul op. A few binary ops can also be fused to it. Transformers based models frequently uses it and the fusions (e.g., BatchMatMul + Mul + Add) in their self-attention.

@mdfaijul mdfaijul requested a review from penpornk as a code owner May 3, 2024 16:22
@google-ml-butler google-ml-butler bot added the size:XL CL Change Size:Extra Large label May 3, 2024
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label May 3, 2024
@github-actions github-actions bot added the kokoro:force-run Tests on submitted change label May 3, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 3, 2024
@github-actions github-actions bot added the kokoro:force-run Tests on submitted change label May 3, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 3, 2024
@bhavani-subramanian
Copy link
Contributor

bhavani-subramanian commented May 3, 2024

@penpornk Just a heads-up that #58204 PR got reverted due to ARM unit test failures. I have pushed a fix in this PR.

@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation May 6, 2024
@gbaned gbaned added the comp:mkl MKL related issues label May 6, 2024
@gbaned
Copy link
Contributor

gbaned commented May 20, 2024

Hi @mdfaijul Can you please rebase your branch and resolve the conflicts? Thank you!

@github-actions github-actions bot added the kokoro:force-run Tests on submitted change label May 20, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 20, 2024
@bhavani-subramanian
Copy link
Contributor

@gbaned @penpornk I have resolved all the merge conflicts. Can you please review this PR? Thanks.

@gbaned
Copy link
Contributor

gbaned commented Jun 7, 2024

Hi @penpornk Can you please review this PR? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Pull request awaiting review comp:mkl MKL related issues size:XL CL Change Size:Extra Large
Projects
PR Queue
  
Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

5 participants