Make Event::PollForStatus a virtual method, and override it where necessary. #68349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_635818137
branch
4 times, most recently
from
1c1eae8
to
1e2e0ce
Compare
…essary. This enables Event to be a completely virtual base class, and removes it from circular dependencies. PiperOrigin-RevId: 636235458
copybara-service
bot
force-pushed
the
exported_pr_635818137
branch
from
1e2e0ce
to
ac74514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Event::PollForStatus a virtual method, and override it where necessary.
This enables Event to be a completely virtual base class, and removes it from circular dependencies.
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12942 from openxla:fix_test_cudnn c438b08ea7240c23ae98bc8dcf4ef45fa6d2e89c