update Defun doc to clarify that definitions are frozen at first .run call #6835
Conversation
|
Can one of the admins verify this patch? |
yaroslavvb
changed the title
|
Jenkins, test this please. |
| @@ -748,6 +748,9 @@ def foo(x, y): | |||
| default graph and adds the definition of the function into the | |||
| default graph. Because the addition of the function into the graph | |||
| is deferred, the decorator can be used anywhere in the program. | |||
|
|
|||
| Definitions of function is frozen for the session after first session.run | |||
There was a problem hiding this comment.
How about
Definitions of functions are frozen in a graph as soon as the graph is used to create a session.
Therefore, nodes using the function must be created in the graph before the corresponding session
is created.
Maybe then add an example.
There was a problem hiding this comment.
That doesn't seem to match current behavior -- I can create a session, then create function node, and then issue first session.run and it works, still want me to change it to that?
yaroslavvb
added
stat:awaiting tensorflower
|
We need to wait two weeks on that one, sorry about that. |
|
@zffchen78 @drpngx Do you have additional comments? Can we merge this or are we still in the two week waiting period mentioned above? |
|
changed to the wording suggested by zf |
|
Thanks @yaroslavvb. @zffchen78 can you take another look, please? |
|
Jenkins, test this please. |
drpngx
added
awaiting testing (then merge)
and removed
stat:awaiting tensorflower
Fixes #6804