Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tensorflow/tensorflow#70581. #70691

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

msteiner-google
Copy link

As per the title, this PR fixes #70581.

The way I went about it is to allow the caller to specify whether or not the code calling the KubernetesClusterResolver is within a K8S cluster or in any other environment outside it.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Jul 1, 2024
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Jul 3, 2024
@keerthanakadiri keerthanakadiri added this to Assigned Reviewer in PR Queue via automation Jul 3, 2024
@keerthanakadiri
Copy link

Hi @MichaelHudgins Can you please review this PR? Thank you .

@MichaelHudgins MichaelHudgins added the ready to pull PR ready for merge process label Jul 3, 2024
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Jul 4, 2024
@keerthanakadiri keerthanakadiri added the prtype:bugfix PR to fix a bug label Jul 10, 2024
@keerthanakadiri keerthanakadiri requested review from MichaelHudgins and removed request for MichaelHudgins July 10, 2024 10:34
@msteiner-google
Copy link
Author

@MichaelHudgins can you add the readytopull tag again to sync the internal cl?

@MichaelHudgins MichaelHudgins added the ready to pull PR ready for merge process label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Pull request awaiting review prtype:bugfix PR to fix a bug ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

Kubernetes cluster resolver fails when running from within a K8S cluster.
4 participants