Disable graph transforms library in windows pip packages. #7082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petewarden
approved these changes
Jan 25, 2017
mrry
reviewed
Jan 26, 2017
| ] + tf_additional_lib_deps() + tf_additional_plugin_deps(), | ||
| ] + if_not_windows([ | ||
| "//tensorflow/tools/graph_transforms:transform_graph_lib", | ||
| ] + tf_additional_lib_deps() + tf_additional_plugin_deps() |
There was a problem hiding this comment.
Missing closing parenthesis for the if_not_windows() call?
mrry
approved these changes
Jan 26, 2017
|
Jenkins, test this please. |
|
http://ci.tensorflow.org/job/tf-pr-win-bzl/1/ running bazel windows tests. |
|
Build failed with: Will also do the same conditional include swig includes. |
|
Jenkins, test this please. |
|
all tests passed (android was failing before, now that is also passing. |
benoitsteiner
pushed a commit
to benoitsteiner/tensorflow
that referenced
this pull request
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.