Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code description #9106

Merged
merged 3 commits into from
Apr 11, 2017
Merged

add code description #9106

merged 3 commits into from
Apr 11, 2017

Conversation

zjj2wry
Copy link
Contributor

@zjj2wry zjj2wry commented Apr 10, 2017

add code description

@tensorflow-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

caisq
caisq previously requested changes Apr 10, 2017
@@ -11,6 +11,8 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""Example of DNNClassifier for Iris plant dataset,with exponential decay"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Per Google Python Style (https://google.github.io/styleguide/pyguide.html), there needs to be

  1. A space after the comma,https://google.github.io/styleguide/pyguide.html
  2. A period after the last word.

Also make sure that the line is <=80 chars wide as you make further changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caisq think you very much, it is helpful. 💯

@drpngx
Copy link
Contributor

drpngx commented Apr 10, 2017

Jenkins, test this please.

@drpngx
Copy link
Contributor

drpngx commented Apr 11, 2017

Jenkins, test this please.

@drpngx drpngx dismissed caisq’s stale review April 11, 2017 01:53

changes addressed.

@drpngx drpngx merged commit 0054c39 into tensorflow:master Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants