Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 8 comments for event_multiplexer tests. #9629

Merged
merged 2 commits into from May 3, 2017
Merged

Add 8 comments for event_multiplexer tests. #9629

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fede19
Add 8 comments for event_multiplexer tests.
chris-chris May 3, 2017
fec4e97
small fixes
May 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions tensorflow/tensorboard/backend/event_processing/event_multiplexer_test.py
View file
Open in desktop
Expand Up @@ -124,16 +124,19 @@ def tearDown(self):
self.stubs.CleanUp()

def testEmptyLoader(self):
"""Tests empty EventMultiplexer creation."""
x = event_multiplexer.EventMultiplexer()
self.assertEqual(x.Runs(), {})

def testRunNamesRespected(self):
"""Tests two EventAccumulators inserted/accessed in EventMultiplexer."""
x = event_multiplexer.EventMultiplexer({'run1': 'path1', 'run2': 'path2'})
self.assertItemsEqual(sorted(x.Runs().keys()), ['run1', 'run2'])
self.assertEqual(x._GetAccumulator('run1')._path, 'path1')
self.assertEqual(x._GetAccumulator('run2')._path, 'path2')

def testReload(self):
"""EventAccumulators should Reload after EventMultiplexer call it."""
x = event_multiplexer.EventMultiplexer({'run1': 'path1', 'run2': 'path2'})
self.assertFalse(x._GetAccumulator('run1').reload_called)
self.assertFalse(x._GetAccumulator('run2').reload_called)
Expand All @@ -142,6 +145,7 @@ def testReload(self):
self.assertTrue(x._GetAccumulator('run2').reload_called)

def testScalars(self):
"""Tests Scalars function returns suitable values."""
x = event_multiplexer.EventMultiplexer({'run1': 'path1', 'run2': 'path2'})

run1_actual = x.Scalars('run1', 'sv1')
Expand All @@ -150,6 +154,7 @@ def testScalars(self):
self.assertEqual(run1_expected, run1_actual)

def testHealthPills(self):
"""Tests HealthPills() returns events associated with run1/Add."""
self.stubs.Set(event_accumulator, 'EventAccumulator',
functools.partial(
_GetFakeAccumulator,
Expand All @@ -172,11 +177,13 @@ def testGetOpsWithHealthPillsWhenHealthPillsAreAvailable(self):
self.assertItemsEqual(['Add'], x.GetOpsWithHealthPills('run1'))

def testExceptions(self):
"""KeyError should be raised when accessing non-existing keys."""
x = event_multiplexer.EventMultiplexer({'run1': 'path1', 'run2': 'path2'})
with self.assertRaises(KeyError):
x.Scalars('sv1', 'xxx')

def testInitialization(self):
"""Tests EventMultiplexer is created properly with its params."""
x = event_multiplexer.EventMultiplexer()
self.assertEqual(x.Runs(), {})
x = event_multiplexer.EventMultiplexer({'run1': 'path1', 'run2': 'path2'})
Expand All @@ -185,6 +192,14 @@ def testInitialization(self):
self.assertEqual(x._GetAccumulator('run2')._path, 'path2')

def testAddRunsFromDirectory(self):
"""Tests AddRunsFromDirectory function.

Tests the following scenarios:
- When the directory does not exist.
- When the directory is empty.
- When the directory has empty subdirectory.
- Contains proper EventAccumulators after adding events.
"""
x = event_multiplexer.EventMultiplexer()
tmpdir = self.get_temp_dir()
join = os.path.join
Expand Down