Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Remove paging from the WebGL backend #1647

Merged
merged 5 commits into from Mar 26, 2019
Merged

Remove paging from the WebGL backend #1647

merged 5 commits into from Mar 26, 2019

Conversation

dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Mar 25, 2019

Paging has been the source of various problems, so we've decided to remove it. Instead we will warn the user when the memory usage in WebGL is above a dynamically decided threshold.


This change is Reviewable

@dsmilkov dsmilkov requested a review from nsthorat March 25, 2019 23:54
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)


src/kernels/backend_webgl.ts, line 181 at r1 (raw file):

// Empirically determined constant used to decide the number of MB on GPU
// before we warn about high memory use. The MB are this constant * screen area
// * dpi / 1024.

woops, realized I wrote this comment.. should be over another 1024, my bad

Copy link
Contributor Author

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained


src/kernels/backend_webgl.ts, line 181 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

woops, realized I wrote this comment.. should be over another 1024, my bad

Done.

@dsmilkov dsmilkov merged commit a3612ae into master Mar 26, 2019
@dsmilkov dsmilkov deleted the remove-paging branch March 26, 2019 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants