Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Speech Commands] Add notebook for training custom models in Python #506

Merged
merged 8 commits into from
Aug 20, 2020

Conversation

caisq
Copy link
Contributor

@caisq caisq commented Aug 10, 2020

in Python, using a set of .wav files.

Fixes tensorflow/tfjs#3719


This change is Reviewable

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@caisq caisq requested a review from pyu10055 August 10, 2020 13:44
@caisq
Copy link
Contributor Author

caisq commented Aug 10, 2020

cc @khanhlvg @lintian06

@caisq caisq changed the title [Speech Commands] Add notebook to show how to train custom audio model [Speech Commands] Add notebook for training custom models in Python Aug 10, 2020
@caisq
Copy link
Contributor Author

caisq commented Aug 12, 2020

Gentle ping @pyu10055. Do you have time to review the PR? Thanks.

@@ -0,0 +1,815 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the questions is if I have a set of .wav files, what part of this script needs to be changed?

Better if this can take a custom directory and require no code changes from user.


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I added a paragraph in this header section to answer that question.

@@ -0,0 +1,815 @@
{
Copy link
Collaborator

@pyu10055 pyu10055 Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this assume numpy, tensorflow, scipy, etc are all pre-installed?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We can safely assume that these libraries are all pre-installed for the following reasons:

  1. They are installed by default on Google Colab.
  2. These three are such widely-used libraries that virtually all data scientists and ML practitioners know how to install them.

@caisq caisq requested a review from pyu10055 August 19, 2020 00:00
@caisq
Copy link
Contributor Author

caisq commented Aug 20, 2020

Ping @pyu10055 if you can take another look at the PR, it would be great. Thanks.

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pyu10055)

@caisq
Copy link
Contributor Author

caisq commented Aug 20, 2020

Thanks for the reviews, @pyu10055 and @lintian06. Merging PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add Colab Notebook to show how to train an audio model from scratch in Python
3 participants