This repository has been archived by the owner on Jul 15, 2022. It is now read-only.
BREAKING Render param order #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caisq
approved these changes
Mar 2, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 20 files reviewed, all discussions resolved (waiting on @caisq and @nsthorat)
nsthorat
approved these changes
Mar 2, 2019
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make the param order of render.* functions match show.*. They both now follow a container first convention.
BREAKING.
This change is