Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

remove the render prefix from render function names. #59

Merged
merged 2 commits into from
Mar 6, 2019

Conversation

tafsiri
Copy link
Contributor

@tafsiri tafsiri commented Mar 6, 2019

This fixes how they are rendered in the docs.


This change is Reviewable

This fixes how they are rendered in the docs.
@tafsiri tafsiri requested a review from nsthorat March 6, 2019 02:20
Copy link

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 20 of 20 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tafsiri)


src/index.ts, line 31 at r1 (raw file):

import {accuracy, confusionMatrix as metricsConfusionMatrix, perClassAccuracy} from './util/math';

const render = {

consider putting these in a render_exports.ts and doing

export * as render from './render_exports';

this will allow you to have tf.metrics.confusionMatrix and tf.render.confusionMatrix and not have the collisions here

Copy link

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tafsiri)


src/index.ts, line 31 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

consider putting these in a render_exports.ts and doing

export * as render from './render_exports';

this will allow you to have tf.metrics.confusionMatrix and tf.render.confusionMatrix and not have the collisions here

also a metrics_exports.ts, show_exports. but completely optional & up to you obviously

Copy link
Contributor Author

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nsthorat)


src/index.ts, line 31 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

also a metrics_exports.ts, show_exports. but completely optional & up to you obviously

Thanks. will consider for future!

@tafsiri tafsiri merged commit 535d16e into master Mar 6, 2019
@tafsiri tafsiri deleted the fix-render-function-names-in-docs branch March 6, 2019 16:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants