Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EncodeBase64 and DecodeBase64 ops #2004

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

vabarbosa
Copy link
Contributor

@vabarbosa vabarbosa commented Sep 9, 2019

This is a re-submission of the EncodeBase64/DecodeBase64 PRs that were in tfjs-core / tfjs-converter / tfjs-node and archived as part of the move to monorepo:


the TF implementation of the pix2pix model which fails conversion because of

Unsupported Ops: DecodeJpeg, EncodePng, DecodeBase64

the Open NSFW model also fails conversion with some of the same ops (#433).

i wanted to try to implement some of these ops in TensorFlow.js. starting with this pull request for DecodeBase64 and EncodeBase64.


To see the logs from the Cloud Build CI, please join either
our discussion
or announcement mailing list.


This change is Reviewable

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@vabarbosa
Copy link
Contributor Author

hello @nsthorat @pyu10055 this is a re-submission of the EncodeBase64/DecodeBase64 PRs that were originially in tfjs-core / tfjs-converter / tfjs-node repos and since archived as part of the move to monorepo. is there anything else needed from me here?

regarding the build failure, looking at the details/log it shows

ERROR: build step 2 "node:10" failed: exit status 2
ERROR: build step 3 "gcr.io/cloud-builders/gcloud" failed: exit status 1

i am not sure at first glance how they maybe related to the code changes. is this something i should be trying to investigate further myself? thanks again.

@vabarbosa
Copy link
Contributor Author

hello @nsthorat @pyu10055 just wanted to check to make sure you are not waiting on me or and there is no additional steps i should be taking? thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants