Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Test WEBGL_PACK=false on CI #2294

Merged
merged 1 commit into from Oct 30, 2019
Merged

[Core] Test WEBGL_PACK=false on CI #2294

merged 1 commit into from Oct 30, 2019

Conversation

dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Oct 30, 2019 •
edited

Significantly increase test coverage for our WebGL backend by testing the WEBGL_PACK=false condition on browserstack.

This change is Reviewable

nsthorat
nsthorat approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @nsthorat and @tafsiri)

@dsmilkov dsmilkov merged commit 02439c8 into master Oct 30, 2019
@dsmilkov dsmilkov deleted the enable-webgl_pack_false_ci branch October 30, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsthorat nsthorat nsthorat approved these changes

@annxingyuan annxingyuan annxingyuan approved these changes

@tafsiri tafsiri Awaiting requested review from tafsiri

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dsmilkov @nsthorat @annxingyuan @googlebot