simplify install script, remove dependency to yarn #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current version of tfjs-node-gpu (1.3.1) requires the installation of yarn (either globally or via package.json) due to the "yarn install-gpu" install script. Renaming the "install-gpu" to "install" should fix this and allow installation without yarn.
kangyizhang
reviewed
Nov 6, 2019
There was a problem hiding this comment.
Thanks for catching it and sending this PR!
Reviewable status: 0 of 1 approvals obtained
kangyizhang
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of tfjs-node-gpu (1.3.1) requires the installation of yarn (either globally or via package.json) due to the "yarn install-gpu" install script. Renaming the "install-gpu" to "install" should fix this and allow installation without yarn.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is