Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASM] Fix allocation issue for buffers with byteOffsets #3334

Merged
merged 1 commit into from
May 27, 2020
Merged

[WASM] Fix allocation issue for buffers with byteOffsets #3334

merged 1 commit into from
May 27, 2020

Conversation

pvaneck
Copy link
Contributor

@pvaneck pvaneck commented May 27, 2020 •
edited by nsthorat

Use the TypedArray byteOffset instead of defaulting to 0.

Fixes: #2998

This change is Reviewable

annxingyuan
annxingyuan approved these changes May 27, 2020
View reviewed changes
Copy link
Collaborator

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @pvaneck !

@annxingyuan annxingyuan merged commit d7ce627 into tensorflow:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annxingyuan annxingyuan annxingyuan approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WASM] The value of tensor created from TypedArray is incorrect
3 participants
@pvaneck @annxingyuan @googlebot