-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Enable SIMD. #3355
[wasm] Enable SIMD. #3355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, but most of the code (TypeScript & build scripts) is outside of my area of expertise
| iPhone X | 147.1 | 20.3 | 941.3 | N/A | | ||
| iPhone XS | 140 | 18.1 | 426.4 | N/A | | ||
| Pixel 3 | 266.2 | 77.3 | 2345.2 | N/A | | ||
| Desktop Linux | 91.5 | 17.1 | 1049 | N/A | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may benchmark on desktop Linux with Chrome Dev or Firefox Nightly
|--------------------------|-------|-------|----------|-------------| | ||
| iPhone X | 147.1 | 20.3 | 941.3 | N/A | | ||
| iPhone XS | 140 | 18.1 | 426.4 | N/A | | ||
| Pixel 3 | 266.2 | 77.3 | 2345.2 | N/A | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chrome on Android supports SIMD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, for some reason the support test I'm using (https://github.com/GoogleChromeLabs/wasm-feature-detect) returns false on Chrome Android, even though in chrome://flags it says it's supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah turns out the feature test only works in Chrome 84+, and I was using Chrome 80. Will work on getting these benchmarks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r1.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, @lina128, @Maratyszcza, @nsthorat, @pyu10055, and @tafsiri)
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is