Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Add where / select. #3376

Merged
merged 13 commits into from
Jun 5, 2020
Merged

[wasm] Add where / select. #3376

merged 13 commits into from
Jun 5, 2020

Conversation

annxingyuan
Copy link
Collaborator

@annxingyuan annxingyuan commented Jun 2, 2020 •
edited by nsthorat

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

lina128
lina128 approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @lina128, @nsthorat, @pyu10055, and @tafsiri)

tafsiri
tafsiri approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @dsmilkov, @nsthorat, @pyu10055, and @tafsiri)

@annxingyuan annxingyuan merged commit 9433568 into master Jun 5, 2020
@annxingyuan annxingyuan deleted the wasm_where branch June 8, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafsiri tafsiri tafsiri approved these changes

@lina128 lina128 lina128 approved these changes

@dsmilkov dsmilkov Awaiting requested review from dsmilkov

@nsthorat nsthorat Awaiting requested review from nsthorat

@pyu10055 pyu10055 Awaiting requested review from pyu10055

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@annxingyuan @tafsiri @lina128 @googlebot