[WASM] Add CommonJS output in rollup #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables usage of the npm package in Node.
annxingyuan
approved these changes
Jun 3, 2020
tafsiri
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
For consistency we could also have the es2017 targets for wasm. I think this would be good unless @annxingyuan you see any barriers to that working.
Thanks @pvaneck!
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @tafsiri)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables usage of the WASM backend NPM package in Node by outputting a cjs ".node.js" file. The
mainin package.json will point to this. This follows the pattern of other modules like tfjs-backend-cpu and tfjs-core.Also did some minor refactoring of common variables.
Note: this rollup config file differs a bit from the ones in other modules, so not sure if intentional or if a consistency update is desired.
This change is