-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize minimum & maximum #3379
Conversation
I also added a new helper script, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @lina128, and @tafsiri)
tfjs-core/src/ops/maximum.ts, line 62 at r2 (raw file):
if ($a.dtype === 'bool') { $a = $a.toInt();
Is this chained? Should we use cast directly?
tfjs-core/src/ops/maximum.ts, line 67 at r2 (raw file):
assertAndGetBroadcastShape($a.shape, $b.shape); const forward: ForwardFunc<Tensor> = (backend, save) => {
Consider also do the type cast in forward func.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @lina128)
tfjs-core/src/ops/maximum.ts, line 62 at r2 (raw file):
Previously, lina128 (Na Li) wrote…
Is this chained? Should we use cast directly?
Done. Good catch
tfjs-core/src/ops/maximum.ts, line 67 at r2 (raw file):
Previously, lina128 (Na Li) wrote…
Consider also do the type cast in forward func.
Done
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is