Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize minimum & maximum #3379

Merged
merged 8 commits into from
Jun 4, 2020
Merged

Modularize minimum & maximum #3379

merged 8 commits into from
Jun 4, 2020

Conversation

tafsiri
Copy link
Contributor

@tafsiri tafsiri commented Jun 2, 2020

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@tafsiri
Copy link
Contributor Author

tafsiri commented Jun 2, 2020

I also added a new helper script, touch_modular_op_files.ts to help create a few empty files and speed up a repetitive action when modularising an op.

Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @lina128, and @tafsiri)


tfjs-core/src/ops/maximum.ts, line 62 at r2 (raw file):

  if ($a.dtype === 'bool') {
    $a = $a.toInt();

Is this chained? Should we use cast directly?


tfjs-core/src/ops/maximum.ts, line 67 at r2 (raw file):

  assertAndGetBroadcastShape($a.shape, $b.shape);

  const forward: ForwardFunc<Tensor> = (backend, save) => {

Consider also do the type cast in forward func.

Copy link
Contributor Author

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @lina128)


tfjs-core/src/ops/maximum.ts, line 62 at r2 (raw file):

Previously, lina128 (Na Li) wrote…

Is this chained? Should we use cast directly?

Done. Good catch


tfjs-core/src/ops/maximum.ts, line 67 at r2 (raw file):

Previously, lina128 (Na Li) wrote…

Consider also do the type cast in forward func.

Done

@tafsiri tafsiri merged commit e4dcecf into master Jun 4, 2020
@tafsiri tafsiri deleted the modularize-min-max branch June 4, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants