Modularise atan2, floorDiv, mod and mul #3407

tafsiri · 2020-06-08T16:13:04Z

This modularizes the remaining binary ops, atan2, floorDiv, mod and mul.

One note about floorDiv: in doing this I noticed we had lost test coverage, i restored an old test for forward pass, however gradient calc didn't have a test. So I didn't remove the chaining api from FloorDiv grad. A followup PR will add tests for the gradient and then we can more safely make edits to that code.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is

annxingyuan

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @lina128, and @tafsiri)

tfjs-core/src/gradients/Atan2_grad.ts, line 42 at r1 (raw file):

      const reduceAxes = getReductionAxes(a.shape, outShape);
      if (reduceAxes.length > 0) {
        res = res.sum(reduceAxes);

avoid chained API

tfjs-core/src/gradients/Atan2_grad.ts, line 44 at r1 (raw file):

        res = res.sum(reduceAxes);
      }
      return res.reshape(a.shape);

avoid chained API

tfjs-core/src/gradients/FloorDiv_grad.ts, line 31 at r1 (raw file):

    const derA = () => {
      const res = dy.div(b.toFloat());

avoid chained API

tfjs-core/src/gradients/FloorDiv_grad.ts, line 34 at r1 (raw file):

      const reduceAxes = getReductionAxes(a.shape, outShape);
      if (reduceAxes.length > 0) {
        return res.sum(reduceAxes).reshape(a.shape);

avoid chained API

tfjs-core/src/gradients/FloorDiv_grad.ts, line 39 at r1 (raw file):

    };
    const derB = () => {
      let res = dy.mul(a.toFloat());

avoid chained API

tfjs-core/src/gradients/FloorDiv_grad.ts, line 42 at r1 (raw file):

      const reduceAxes = getReductionAxes(b.shape, outShape);
      if (reduceAxes.length > 0) {
        res = res.sum(reduceAxes).reshape(b.shape);

avoid chained API

tfjs-core/src/gradients/FloorDiv_grad.ts, line 44 at r1 (raw file):

        res = res.sum(reduceAxes).reshape(b.shape);
      }
      const tmp = b.square();

avoid chained API

tfjs-core/src/gradients/FloorDiv_grad.ts, line 45 at r1 (raw file):

      }
      const tmp = b.square();
      return res.div(tmp.toFloat()).neg();

avoid chained API

lina128

+1 to Ann's comments.

Reviewable status: complete! 2 of 1 approvals obtained (waiting on @lina128 and @tafsiri)

tafsiri

Reviewable status: complete! 2 of 1 approvals obtained (waiting on @annxingyuan)

tfjs-core/src/gradients/Atan2_grad.ts, line 42 at r1 (raw file):