[wasm] Add transpose support to Max kernel.

[annxingyuan]

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

---

This change is 

[tafsiri]

Reviewed 3 of 3 files at r1.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, @lina128, @nsthorat, @pyu10055, and @tafsiri)

---

tfjs-backend-wasm/src/kernels/Max.ts, line 40 at r1 (raw file):

  let xShape = x.shape;
  const xRank = x.shape.length;
  const xVals = backend.typedArrayFromHeap(x);

Should this move inside the if(backend.dataIdMap.get ...) block? Is it used outside of that block

---

tfjs-backend-wasm/src/kernels/Max.ts, line 58 at r1 (raw file):

    if (backend.dataIdMap.get(xTransposed.dataId).id !== xId) {
      // If perm is not no-op.

could you expand this comment a bit, e.g. what is perm? also the double negative makes it slightly harder to ready. Maybe something like 'if x was permuted/transposed'

[annxingyuan]

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @lina128, @nsthorat, @pyu10055, and @tafsiri)

---

tfjs-backend-wasm/src/kernels/Max.ts, line 40 at r1 (raw file):

Previously, tafsiri (Yannick Assogba) wrote…

Should this move inside the if(backend.dataIdMap.get ...) block? Is it used outside of that block

Done

---

tfjs-backend-wasm/src/kernels/Max.ts, line 58 at r1 (raw file):

Previously, tafsiri (Yannick Assogba) wrote…

could you expand this comment a bit, e.g. what is perm? also the double negative makes it slightly harder to ready. Maybe something like 'if x was permuted/transposed'

Done