Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tests of tf.profile #3761

Merged
merged 4 commits into from Aug 10, 2020
Merged

Fix the tests of tf.profile #3761

merged 4 commits into from Aug 10, 2020

Conversation

Linchenn
Copy link
Collaborator

@Linchenn Linchenn commented Aug 10, 2020

The tf.profile()'s tests expect the kernelTimeMs and extraInfo have been resolved from Promise, but the kernelTimeMs in tf.profile()'s return value can not only be number type, but also {error: string}, as:

type KernelInfo = {
  ...
  kernelTimeMs: number | {error: string} | Promise<number|{error: string}>;
  extraInfo: string | Promise<string>;
};

(at https://github.com/tensorflow/tfjs/blob/master/tfjs-core/src/engine.ts#L55)

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@Linchenn Linchenn merged commit 94f959d into tensorflow:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants