[tfjs-node]Support cnpm registry #3832
Conversation
|
Pass the url through the environment variable But for the developer, he does not know this url: https://cdn.npm.taobao.org/dist/. |
There was a problem hiding this comment.
Pass the url through the environment variable
STORE_BASE_HOST=https://cdn.npm.taobao.org/dist/const BASE_HOST = process.env.STORE_BASE_HOST;But for the developer, he does not know this url: https://cdn.npm.taobao.org/dist/.
So is it possible to tell the developer this information in the installation document
Thanks, Is this change pushed?
already pushed |
|
should i use it like could give a example url of path corresponding |
| @@ -42,8 +42,9 @@ const mkdir = util.promisify(fs.mkdir); | |||
| const rename = util.promisify(fs.rename); | |||
| const rimrafPromise = util.promisify(rimraf); | |||
|
|
|||
| const BASE_URI = | |||
| 'https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-'; | |||
| const CDN_STORAGE = process.env.CDN_STORAGE; | |||
There was a problem hiding this comment.
process.env.CND_STORAGE name as process.env.TFJS_NODE_MIRROR may more meaningful
|
it's seems already published,i track this from a old third node modules😰 pity for that, but we can also use make it work |
Support taobao npm mirror.
When tfjs-node is installed, it will download files from storage.googleapis.com.
In China, the cnpm tool will be used to solve network problems, and it will proxy the above-mentioned link to the mirror site.
However, when some people only use the parameter (
--registry=https://registry.npm.taobao.org) to install, they cannot proxy.This pr is to solve this problem: only use the link installed by the parameter (
--registry=https://registry.npm.taobao.org)This change is